fix: Don't crash when trying to update the shebang in a binary script (…

…#1710)
pdm-project · Feb 14, 2023 · 72c82f5 · 72c82f5
1 parent 29cfff9
commit 72c82f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/news/1709.bugfix.md b/news/1709.bugfix.md
@@ -0,0 +1 @@
+Don't crash when trying to update the shebang in a binary script.
diff --git a/src/pdm/models/environment.py b/src/pdm/models/environment.py
@@ -63,10 +63,10 @@ def _replace_shebang(contents: bytes, new_executable: bytes) -> bytes:
     match = re.search(_complex_shebang_re, contents, flags=re.M)
     if match:
         return contents.replace(match.group(1), new_executable, 1)
-    else:
-        match = re.search(_simple_shebang_re, contents, flags=re.M)
-        assert match is not None
+    match = re.search(_simple_shebang_re, contents, flags=re.M)
+    if match:
         return contents.replace(match.group(1), new_executable, 1)
+    return contents
 
 
 class PackageFinder(unearth.PackageFinder):