Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override editable installation #1011

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Don't override editable installation #1011

merged 2 commits into from
Apr 2, 2022

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1011 (85b5c3e) into main (2f3ff2d) will increase coverage by 0.39%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   83.50%   83.89%   +0.39%     
==========================================
  Files          73       73              
  Lines        6439     6453      +14     
  Branches     1336     1342       +6     
==========================================
+ Hits         5377     5414      +37     
+ Misses        745      711      -34     
- Partials      317      328      +11     
Flag Coverage Δ
unittests 83.65% <74.07%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/actions.py 79.45% <33.33%> (-0.44%) ⬇️
pdm/installers/synchronizers.py 84.84% <75.00%> (+0.30%) ⬆️
pdm/models/candidates.py 90.00% <100.00%> (-0.04%) ⬇️
pdm/resolver/providers.py 94.95% <100.00%> (+0.08%) ⬆️
pdm/models/setup.py 52.96% <0.00%> (+10.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3ff2d...85b5c3e. Read the comment docs.

@frostming frostming merged commit c4904bf into main Apr 2, 2022
@frostming frostming deleted the feature/keep-editable branch April 2, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants