Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in parsing conditional requirements in setup.py #1264

Closed
1 task done
00sapo opened this issue Jul 22, 2022 · 1 comment
Closed
1 task done

Error in parsing conditional requirements in setup.py #1264

00sapo opened this issue Jul 22, 2022 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@00sapo
Copy link

00sapo commented Jul 22, 2022

  • I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

with python >= 3.8 do:

pdm add "fairseq @ git+https://github.com/pytorch/fairseq@336942734c85791a90baa373c212d27e7c722662"

Actual behavior

PDM fails, saying that the package has conflicting requirements. Actually, looking at the setup.py, it has two conditional constraints, but pdm stops at the first one:

https://github.com/facebookresearch/fairseq/blob/336942734c85791a90baa373c212d27e7c722662/setup.py#L185-L186

Expected behavior

Should install normally, as with pip.

Environment Information

# Paste the output of `pdm info && pdm info --env` below:
PDM version:
  2.0.3
Python Interpreter:
  /extra/Develop/Didone/DidoneBERT/dustenv/pyenv/versions/3.8.13/bin/python3.8 (3.8)
Project Root:
  /extra/Develop/Didone/DidoneBERT
Project Packages:
  /extra/Develop/Didone/DidoneBERT/__pypackages__/3.8
{
  "implementation_name": "cpython",
  "implementation_version": "3.8.13",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "5.10.129-1-MANJARO",
  "platform_system": "Linux",
  "platform_version": "#1 SMP PREEMPT Thu Jul 7 16:56:51 UTC 2022",
  "python_full_version": "3.8.13",
  "platform_python_implementation": "CPython",
  "python_version": "3.8",
  "sys_platform": "linux"
}
@00sapo 00sapo added the 🐛 bug Something isn't working label Jul 22, 2022
@00sapo
Copy link
Author

00sapo commented Jul 23, 2022

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant