Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the poorly visible default colors #1450

Closed
eugenesvk opened this issue Oct 19, 2022 · 5 comments · Fixed by #1452
Closed

Allow changing the poorly visible default colors #1450

eugenesvk opened this issue Oct 19, 2022 · 5 comments · Fixed by #1452
Labels
⭐ enhancement Improvements for existing features

Comments

@eugenesvk
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The default color scheme makes the text poorly visible on a solarized color scheme

pdm

Describe the solution you'd like

A way to override the values of the default colors

@eugenesvk eugenesvk added the ⭐ enhancement Improvements for existing features label Oct 19, 2022
@pawamoy
Copy link
Sponsor Contributor

pawamoy commented Oct 19, 2022

I'd say that it's an issue with the solarized theme. The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme. When I change my theme, the colors change as well. The solarized background and the dimmed colors do not seem to play well together, but that's not something PDM (and more generally console tools) could or should really plan for (it's impossible to support themes of each and every user). Happy to hear otherwise!

If @frostming is OK for color configuration within PDM, I welcome it as well 🙂

@eugenesvk
Copy link
Contributor Author

The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme

That's a distinction without a difference — the fact is I can't change the colors only for this app without changing the hardcoded ANSI sequence within the app, otherwise I'd be happy to change cyan to black in my theme

The solarized background and the dimmed colors do not seem to play well together

It's not just the dimmed colors, the default also isn't great. And not just on a solarized bg: pure white background doesn't really help
It's more of an issue with cyan being used for something bigger than a symbol or two

it's impossible to support themes of each and every user

Just testing with the 2 most common backgrounds (black and white) would be fine, no need for ∞
Also, using default foreground colors would avoid this mistake since they're properly set everywhere by the user choosing the theme
And allowing user config is always a good escape from having to design everything yourself!
Impossible Is Nothing™

@laike9m
Copy link
Contributor

laike9m commented Jul 6, 2023

Having the same issue under a light solarized shell theme

image

There's no configuration for it, but I could be wrong
https://pdm.fming.dev/latest/reference/configuration/#color-theme

@frostming
Copy link
Collaborator

There's no configuration for it, but I could be wrong

Weird, we only apply the bold style here, and the text color should follow the default theme color. Here is what it looks like on my side, mac terminal with default theme:

image

@laike9m
Copy link
Contributor

laike9m commented Jul 6, 2023

Found out it's iterm2 that overrides this..after turning it off things work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants