-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing the poorly visible default colors #1450
Comments
I'd say that it's an issue with the solarized theme. The colors are not really hardcoded: they actually are an ANSI sequence with a particular number, and this number is associated to a particular color by the terminal/theme. When I change my theme, the colors change as well. The solarized background and the dimmed colors do not seem to play well together, but that's not something PDM (and more generally console tools) could or should really plan for (it's impossible to support themes of each and every user). Happy to hear otherwise! If @frostming is OK for color configuration within PDM, I welcome it as well 🙂 |
That's a distinction without a difference — the fact is I can't change the colors only for this app without changing the hardcoded ANSI sequence within the app, otherwise I'd be happy to change cyan to black in my theme
It's not just the dimmed colors, the default also isn't great. And not just on a solarized bg: pure white background doesn't really help
Just testing with the 2 most common backgrounds (black and white) would be fine, no need for ∞ |
Having the same issue under a light solarized shell theme There's no configuration for it, but I could be wrong |
Weird, we only apply the |
Found out it's iterm2 that overrides this..after turning it off things work fine. |
Is your feature request related to a problem? Please describe.
The default color scheme makes the text poorly visible on a solarized color scheme
Describe the solution you'd like
A way to override the values of the default colors
The text was updated successfully, but these errors were encountered: