Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tool configurations under setup.cfg to pyproject.toml #2703

Closed
boholder opened this issue Mar 19, 2024 · 2 comments · Fixed by #2711
Closed

Move tool configurations under setup.cfg to pyproject.toml #2703

boholder opened this issue Mar 19, 2024 · 2 comments · Fixed by #2711
Labels
⭐ enhancement Improvements for existing features

Comments

@boholder
Copy link
Contributor

Describe the solution you'd like

This repo's setup.cfg file contains configurations about three tools: codespell, coverage and mypy.
According to their (newest) documentation, all three tools support to be configured via pyproject.toml:

By moving configurations to pyproject.toml, we can get rid of setup.cfg, that's what I want, but I'm not sure if it's properly to do.
@boholder boholder added the ⭐ enhancement Improvements for existing features label Mar 19, 2024
@frostming
Copy link
Collaborator

Sounds great, are you interested in contributing to this?

@boholder
Copy link
Contributor Author

Sounds great, are you interested in contributing to this?

Sure, on going.

boholder added a commit to boholder/pdm that referenced this issue Mar 21, 2024
@boholder
chore: move tool configurations under setup.cfg to pyproject.toml, re…
ccf9937 
…move setup.cfg

close pdm-project#2703
boholder added a commit to boholder/pdm that referenced this issue Mar 21, 2024
@boholder
chore: delete setup.cfg, move tool configurations under it to pyproje…
f89e656 
…ct.toml

close pdm-project#2703
@boholder boholder mentioned this issue Mar 21, 2024
Merged
1 task
boholder added a commit to boholder/pdm that referenced this issue Mar 21, 2024
@boholder
chore: delete setup.cfg, move tool configurations under it to pyproje…
ab6bfe5 
…ct.toml

close pdm-project#2703
frostming pushed a commit that referenced this issue Mar 22, 2024
@boholder
chore: delete setup.cfg, move tool configurations under it to `pypr…
93cd081 
…oject.toml` (#2711)

* chore: delete setup.cfg, move tool configurations under it to pyproject.toml

close #2703

* fix: fix broken ci.yml due to absent of setup.cfg file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: delete setup.cfg, move tool configurations under it to pyproject.toml boholder/pdm
2 participants
@frostming @boholder