Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint with Ruff #1715

Merged
merged 3 commits into from
Feb 16, 2023
Merged

chore: lint with Ruff #1715

merged 3 commits into from
Feb 16, 2023

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Feb 16, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

  • Use Ruff as the linter
  • Change max line length to 120

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 85.22% // Head: 85.12% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (0c60b4d) compared to base (870f712).
Patch coverage: 85.99% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   85.22%   85.12%   -0.10%     
==========================================
  Files          92       92              
  Lines        8631     8634       +3     
  Branches     1864     1863       -1     
==========================================
- Hits         7356     7350       -6     
- Misses        858      865       +7     
- Partials      417      419       +2     
Flag Coverage Δ
unittests 84.94% <85.99%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/search.py 67.34% <0.00%> (ø)
src/pdm/cli/commands/venv/remove.py 88.00% <0.00%> (ø)
src/pdm/installers/core.py 100.00% <ø> (ø)
src/pdm/models/project_info.py 94.28% <ø> (ø)
src/pdm/models/backends.py 84.70% <50.00%> (ø)
src/pdm/models/environment.py 67.19% <57.14%> (ø)
src/pdm/builders/editable.py 77.14% <60.00%> (ø)
src/pdm/cli/commands/config.py 85.29% <60.00%> (ø)
src/pdm/cli/commands/cache.py 83.33% <66.66%> (ø)
src/pdm/cli/commands/venv/backends.py 88.57% <66.66%> (ø)
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit f6cc4eb into main Feb 16, 2023
@frostming frostming deleted the lint/ruff branch February 16, 2023 01:22
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants