Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proxy (HTTP_PROXY) settings are ignored for custom Repositories #2882

Merged
merged 1 commit into from
May 15, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #2880

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #2880

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (a3307c2) to head (f9e78d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2882   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         106      106           
  Lines       10583    10587    +4     
  Branches     2301     2303    +2     
=======================================
+ Hits         9022     9026    +4     
  Misses       1088     1088           
  Partials      473      473           
Flag Coverage Δ
unittests 85.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit ba6645a into main May 15, 2024
21 of 24 checks passed
@frostming frostming deleted the frostming/issue2880 branch May 15, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy (HTTP_PROXY) settings are ignored for custom Repositories
1 participant