Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pdm install --no-isolation uses required build dependencies #2950

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #2944

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #2944

Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (34d1ad5) to head (9eea08e).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pdm/builders/editable.py 60.00% 0 Missing and 4 partials ⚠️
src/pdm/builders/wheel.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   85.33%   85.30%   -0.04%     
==========================================
  Files         106      106              
  Lines       10687    10698      +11     
  Branches     2330     2337       +7     
==========================================
+ Hits         9120     9126       +6     
  Misses       1094     1094              
- Partials      473      478       +5     
Flag Coverage Δ
unittests 85.08% <82.75%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming marked this pull request as ready for review June 18, 2024 01:14
@frostming frostming merged commit 4660b9d into main Jun 18, 2024
22 of 24 checks passed
@frostming frostming deleted the frostming/issue2944 branch June 18, 2024 01:20
@amolenaar
Copy link

Thanks @frostming. It works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm install --no-isolation uses required build dependencies
2 participants