-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append & Merge PdPipeline Stages for Joining Pandas DataFrames #47
Comments
Sure, I'd appreciate any contribution! :) And thank you for the kind words. :) |
Hi, can we close this issue.? I already raised a pull request with this features #48 Let me know, if you need any help in migrating to GitHub actions/releasing the changes. |
Hey @Asrst , Sorry for the belated response! :) I'd love it if you can rebase over the current head of the Cheers, |
By the way, you can see here your code reduces test coverage below 100% (which we cannot have): Please enrich tests to cover all cases you accounted for in your code. I don't want to use that PR (#53, mine), as it has two merge commits. I rather you rebase over the master and open a PR with a single code commit, which I can then fast-forward to, to avoid a merge commit completely. :) |
Hey @Asrst , I'm so sorry. I just got to reading the PR, and unfortunately the current implementation does not make a lot of sense. Can you explain the use case? Share your use of it? I think stages using the If your use case is very specific, I would prefer you stick with a |
Thanks for this library, it made my pandas workflow clean & easy to maintain.
Feature Request:
pd.merge
is a common operation when dealing with 2 or more data frames & pipeline stage for this is missing.Currently, I am implementing a custom pipeline stage
pdp.Merge
fromPdPipelineStage
& would like to contribute.The text was updated successfully, but these errors were encountered: