Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position #3

Closed
pdrbrnd opened this issue Jul 30, 2021 · 7 comments · Fixed by #6
Closed

Scroll position #3

pdrbrnd opened this issue Jul 30, 2021 · 7 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@pdrbrnd
Copy link
Owner

pdrbrnd commented Jul 30, 2021

Description:

After opening a movie detail, the scroll is not kept in the correct place and we're forced to scroll back up.

@jca41
Copy link
Contributor

jca41 commented Aug 2, 2021

Are you taking contributors? Would like to help on this!

@pdrbrnd
Copy link
Owner Author

pdrbrnd commented Aug 3, 2021

sure! I don't see why not

@jca41
Copy link
Contributor

jca41 commented Aug 3, 2021

👍 awesome!
Regarding dev setup, are you able to provide a mock with a few movies so i don't need API access?
Or do you have a test environment?

@pdrbrnd
Copy link
Owner Author

pdrbrnd commented Aug 3, 2021

@jca41 just updated .env.example with the graphql endpoint – which is not a secret at all. It's just there for convenience when switching environments.

now you should be able to run the project.

thanks for the help :)

@jca41
Copy link
Contributor

jca41 commented Aug 3, 2021

@pdrbrnd What node version are you using? Getting a few prettier errors, i'm using 15.8.

@pdrbrnd
Copy link
Owner Author

pdrbrnd commented Aug 3, 2021

@jca41 I'm at 16.2 but I don't think that's the problem.
we had a few updates at significa-style that probably should have been a major bump and I'm not using exact versions in this project.

I'll update the packages.

sorry about that, I wasn't counting on collaboration here 😅

@jca41
Copy link
Contributor

jca41 commented Aug 3, 2021

using npm fixed it for me 😄 was using yarn initially.

@pdrbrnd pdrbrnd closed this as completed in #6 Aug 3, 2021
@pdrbrnd pdrbrnd added the bug Something isn't working label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants