Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1J00_1700 #6

Merged
merged 18 commits into from
Mar 22, 2024
Merged

Release/1J00_1700 #6

merged 18 commits into from
Mar 22, 2024

Conversation

rsjoyner
Copy link
Contributor

@rsjoyner rsjoyner commented Mar 21, 2024

Summary

Updated to newest version of the CART LDD; 1J00_1970
Updated to IM version 1.20.00

Copy link
Collaborator

@lylehuber lylehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say PDS4_CASSINI_1J00_1700 somewhere?

@jordanpadams
Copy link
Contributor

@lylehuber @rsjoyner missing update to pds4_versions.txt file to include 1J00 version

@jordanpadams
Copy link
Contributor

@jordanpadams
Copy link
Contributor

Screenshot 2024-03-21 at 10 13 32 AM

@jordanpadams
Copy link
Contributor

@lylehuber @rsjoyner If this is a bug in LDDTool, we can open a ticket over there.

@rsjoyner
Copy link
Contributor Author

Yes. I think this is a bug in LDDTool. I will work with Steve to make sure that I am not doing something way stupid in the LDDTOOL command.

@jordanpadams
Copy link
Contributor

@rsjoyner do you need to include the CART LDD as well since the schematron references it?

@jordanpadams
Copy link
Contributor

@rsjoyner that is the issue... do the CART LDD needs to be added to his repo.

https://pds-data-dictionaries.github.io/getting-started/ldd-repo-overview.html#handling-ldd-dependencies

@jordanpadams
Copy link
Contributor

Let me know if you run into issues

@rsjoyner
Copy link
Contributor Author

While we are waiting for Steve to reply. See the enclosure for the edited version of the schematron file with the required fix.
Is there a way to use these files in lieu of the "build" ?

CASSINI_LDD_1J00_1700_20240320.zip

@jordanpadams
Copy link
Contributor

jordanpadams commented Mar 21, 2024

@rsjoyner @lylehuber this is not a bug in LDDTool:

lddtool -lpJ ldd-cassini/src/PDS4_CASSINI_IngestLDD.xml ldd-cart/src/PDS4_CART_IngestLDD.xml

produces all valid files.

So if we add that to the dependencies to this repo per these instructions, the automation will work and the files will be accurate

@rsjoyner
Copy link
Contributor Author

lddtool -lpJ ldd-cassini/src/PDS4_CASSINI_IngestLDD.xml ldd-cart/src/PDS4_CART_IngestLDD.xml

  1. I tried a functionally similar command on local copies of the 3 LDDs (e.g., cassini, cart, and geom):

lddtool_1E30_edited -lpJ1 -V 1J00 PDS4_CASSINI_IngestLDD.xml PDS4_CART_IngestLDD.xml PDS4_GEOM_IngestLDD.xml > log-a.txt

lddtool crashed again.

  1. I tried again referencing only the 2 LDDs (e.g., cassini and cart) and lddtool crashed again).

I am using:

LDDTool Version: 14.3.0
Built with IM Version: 1.21.0.0
Build Date: 2023-09-18 21:33:49
Configured IM Versions: [1L00, 1K00, 1J00, 1I00, 1H00, 1G00, 1F00, 1E00, 1D00, 1C00, 1B10, 1B00]

@rsjoyner rsjoyner requested a review from a team as a code owner March 22, 2024 19:08
@rsjoyner rsjoyner requested a review from a team as a code owner March 22, 2024 19:36
@jordanpadams
Copy link
Contributor

@lylehuber @rsjoyner this is fixed and ready for review/merge

Copy link
Collaborator

@lylehuber lylehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works now.

@jordanpadams
Copy link
Contributor

@lylehuber one minor update to remove an unnecessary submodule for ldd-geom.

@jordanpadams
Copy link
Contributor

jordanpadams commented Mar 22, 2024

A fun first corner case of nested dependencies. Had to implement recursion to handle it.

@jordanpadams jordanpadams merged commit ef49f67 into main Mar 22, 2024
@jordanpadams
Copy link
Contributor

@lylehuber I merged it for you. Once it tags a release here, you can submit a ticket to get it put online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants