-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1J00_1700 #6
Conversation
Updated to current version of the CART LDD -- 1J00_1970
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say PDS4_CASSINI_1J00_1700 somewhere?
@lylehuber @rsjoyner missing update to |
@lylehuber also looks like there is a bug somewhere: https://github.com/pds-data-dictionaries/ldd-cassini/actions/runs/8378014955/job/22941538520 |
@lylehuber @rsjoyner If this is a bug in LDDTool, we can open a ticket over there. |
Yes. I think this is a bug in LDDTool. I will work with Steve to make sure that I am not doing something way stupid in the LDDTOOL command. |
@rsjoyner do you need to include the CART LDD as well since the schematron references it? |
@rsjoyner that is the issue... do the CART LDD needs to be added to his repo. |
Let me know if you run into issues |
While we are waiting for Steve to reply. See the enclosure for the edited version of the schematron file with the required fix. |
@rsjoyner @lylehuber this is not a bug in LDDTool:
produces all valid files. So if we add that to the dependencies to this repo per these instructions, the automation will work and the files will be accurate |
lddtool_1E30_edited -lpJ1 -V 1J00 PDS4_CASSINI_IngestLDD.xml PDS4_CART_IngestLDD.xml PDS4_GEOM_IngestLDD.xml > log-a.txt lddtool crashed again.
I am using: LDDTool Version: 14.3.0 |
@lylehuber @rsjoyner this is fixed and ready for review/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this works now.
@lylehuber one minor update to remove an unnecessary submodule for ldd-geom. |
A fun first corner case of nested dependencies. Had to implement recursion to handle it. |
@lylehuber I merged it for you. Once it tags a release here, you can submit a ticket to get it put online. |
Summary
Updated to newest version of the CART LDD; 1J00_1970
Updated to IM version 1.20.00