Add spacecraft state information and Ralph/LEISA details #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze conversion constant class
acraugh
reviewed
Mar 28, 2024
build/development/2510fb68d5d5df03d6ee65e75ec7946e4f3fcea6/1.21.0.0/PDS4_NH_1L00_1000.sch
Show resolved
Hide resolved
acraugh
reviewed
Mar 28, 2024
acraugh
reviewed
Mar 28, 2024
acraugh
reviewed
Mar 28, 2024
acraugh
reviewed
Mar 28, 2024
There was a problem hiding this comment.
There's a problem here with explicit local directory references that need to be removed. Also needs detailed review and resolution with other versions.
There was a problem hiding this comment.
Adding this to the general "doc/regression cleanup" task.
acraugh
reviewed
Mar 28, 2024
acraugh
reviewed
Mar 28, 2024
acraugh
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Have to think about this - this is changing an existing regression test, which should NEVER happen.
acraugh
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Another changed regression test...
acraugh
reviewed
Mar 28, 2024
|
Yes. I'll merge them in that order, but I don't see any reference to LEISA
in the document updates in either branch. I'm wondering how they are going
to spontaneously appear. Did I miss something? Or maybe there are no actual
LEISA classes yet, and thus nothing to mock up...
…-Anne.
On Thu, Mar 28, 2024 at 6:10 PM Caden Gobat ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On docs/source/detailed/outline.rst
<#12 (comment)>
:
The way I did these two PRs is a little weird in that this one branches
off of #11 <#11>, so
all of #11 <#11>'s
changes are here as well. When #11
<#11> gets merged, it
will work out and then only the new stuff here will appear in the change
set.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBV2QEC64N7NCZKBN7G4PTY2SIM5AVCNFSM6AAAAABEFYGJF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRXGQ2TGNBWGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Right, I was just pointing out that most of your comments along the lines of " |
|
Nope, should be good to go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Spacecraft_State,LEISA_Details, andRalph_Detailsclasses, plus associated attributes.NOTE: this PR's source branch builds on the
proposed-changesbranch, and should only be merged after #11 so as to avoid weirdness.Test Data and/or Report
The
Spacecraft_Stateclass has been added to the existing MVIC test labels (see 91b2e94), and everything builds/passes as expected.Related Issues
Builds on pull request #11. Other than that, no associated issues.