Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion in buildImage with default tag #132

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

elpdt852
Copy link
Collaborator

Fix #131

Given that buildImage produces an OCI tarball that you can copyToRegistry as a different image ref, I don't think its worth complicating the tag to produce something input-addressed. This resolves the infinite recursion for buildImage calls without a tag defined, unfortunately I don't think it ever worked.

@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Mar 23, 2024
Copy link
Collaborator

@graham33 graham33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a check failure but makes sense

@RobbieBuxton
Copy link
Collaborator

Looks like there's a check failure but makes sense

I think the check error might just be an CI issue but not sure?

copying path '/nix/store/l974pi8a5yqjrjlzmg6apk0jwjv81yqw-findutils-4.9.0' from 'http://127.0.0.1:37515/'...
copying path '/nix/store/ppy5gm6r676chda5ig5xgbhr8sb3rfap-stdenv-linux' from 'http://127.0.0.1:37515/'...
building '/nix/store/z3yhs5fb3xw5pv4agbzjmw2sl441sy0b-golangci-lint.drv'...
running post-build-hook '/tmp/magic-nix-cache-build-hook-4Jltz6'...
error: unable to execute '/nix/store/vx6kg7g2xj6skg6cpqhxwsm08k6747i1-golangci-lint/bin/golangci-lint': Exec format error

I tried re-running it but it didn't help.

@elpdt852 elpdt852 force-pushed the fix/default-tag branch 3 times, most recently from 82597a2 to 0b587a7 Compare March 24, 2024 00:48
@elpdt852
Copy link
Collaborator Author

I've tried several things:

  • Purging the GitHub action cache
  • Running it locally on my NixOS laptop (it works)
  • Running it on PDT's GitHub action runner (same error)

Disabling it for now. Perhaps we can fix it with a flake update to bump golangci-lint version but leaving it out of scope for this PR to unblock checks.

@elpdt852 elpdt852 merged commit 1c9c03f into main Mar 24, 2024
12 checks passed
@elpdt852 elpdt852 deleted the fix/default-tag branch March 24, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolvedByNix=false leads to infinite recursion
3 participants