Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s: use default buildGoModule #138

Closed
wants to merge 1 commit into from

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented May 9, 2024

buildGo120Module is not available for NixOS 24.05

buildGo120Module is not available for NixOS 24.05
@RobbieBuxton RobbieBuxton added the ok-to-test Runs NixOS tests label May 9, 2024
@RobbieBuxton
Copy link
Collaborator

RobbieBuxton commented May 10, 2024

@ck3d this seems to break the k3s integration tests? (it doesn't appear to be starting properly). Do you have a link to the PR/Commit where they remove buildGo120Module by any chance, I had a look but couldn't find anything. I wouldn't mind reading into it a little bit more.

@RobbieBuxton
Copy link
Collaborator

I just double checked that it's not our CI that's broken, I managed to replicate the errors on my machine. If you try any ofnix run .#test-k3s-rootless, nix run .#test-k3s-external or nix run .#test-k3s you should be able to reproduce the error.

@RobbieBuxton
Copy link
Collaborator

RobbieBuxton commented May 10, 2024

I'm pretty sure the bug is this. I suspect this is why we were building with Go120 in the first place? I might pull @elpdt852 in on this one.

The solution AUR seems to be using is to cherry pick this PR

@elpdt852
Copy link
Collaborator

@RobbieBuxton thanks for root causing this. That looks correct, see if you can use fetchpatch to simply apply the patch from GitHub's API: https://patch-diff.githubusercontent.com/raw/k3s-io/k3s/pull/9064.patch

@ck3d
Copy link
Contributor Author

ck3d commented May 11, 2024

Go 1.20 was removed with NixOS/nixpkgs#295077

I can confirm, the tests fail. So, I close this PR.

@ck3d ck3d closed this May 11, 2024
@RobbieBuxton
Copy link
Collaborator

I'll have a go at switching it over, thanks for the heads up @ck3d much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants