Skip to content

Commit

Permalink
[refact] lint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
gabteles committed Jun 30, 2017
1 parent 7ced227 commit 471f721
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 15 deletions.
8 changes: 5 additions & 3 deletions bin/console
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
require "bundler/setup"
require "br_invoices_pdf"
require "irb"
#!/usr/bin/env ruby

require 'bundler/setup'
require 'br_invoices_pdf'
require 'irb'
IRB.start
9 changes: 7 additions & 2 deletions lib/br_invoices_pdf/cfe/parser.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module BrInvoicesPdf
module Cfe
class Parser
module Parser
module_function

# atributos
# company_name -> emit,xNome
# trading_name -> emit,xFant
Expand All @@ -13,8 +15,11 @@ class Parser
# cfe_number -> ide,NFCE
# cpf -> ide,NFCE

def parse(xml)
def parse(_xml)
# Retornar uma hash com todos os atributos necessarios
{

}
end
end
end
Expand Down
8 changes: 2 additions & 6 deletions lib/br_invoices_pdf/cfe/renderer.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
module BrInvoicesPdf
module Cfe
class Renderer
def render(data, options)
pdf(data, options).render
end

private
module Renderer
module_function

def pdf(data, options)
Prawn::Document.new(options) do |pdf|
Expand Down
9 changes: 5 additions & 4 deletions lib/br_invoices_pdf/generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ class Generator
PDF_OPTIONS = { page_size: 'A4', margin: [40, 75] }.freeze

def initialize(renderer, parser)
@renderer = renderer.new
@parser = parser.new
@renderer = renderer
@parser = parser
end

def generate(xml, options)
data = @parser.parse(xml)
parsed_xml = Ox.parse(xml)
data = @parser.parse(parsed_xml)
opts = PDF_OPTIONS.merge(options)
@renderer.render(data, opts)
@renderer.pdf(data, opts).render
end
end
end

0 comments on commit 471f721

Please sign in to comment.