Fix automatic module name #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`moduleName` is a property inside `KotlinCompilation` which wins the resolution. Inlining value fixes this issue
pdvrieze
added a commit
that referenced
this pull request
Jan 10, 2022
Alternative fix to pull request #79.
|
Hi @pdvrieze, |
|
I will probably just do it soon. I am about to finish DOM support across all platforms. |
|
Just released 0.84.0 (with this fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleNameis a property insideKotlinCompilationwhich wins the resolution. This causesAutomatic-Module-Nameinside manifest to have a name of compilation, such asxmlutil-serialization_woodstoxTest. Inlining value fixes this issue.Probably, a better solution would be to move this block from
compilations.all {}tojvm {}scope. But I'm not sure if it can cause any unwanted side effects for the build.