Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS Big Sur Safari 15.2 map issues so far #23

Closed
crschnick opened this issue Jan 24, 2022 · 2 comments
Closed

MacOS Big Sur Safari 15.2 map issues so far #23

crschnick opened this issue Jan 24, 2022 · 2 comments
Labels
map

Comments

@crschnick
Copy link
Collaborator

This is how the map looks like for me on Big Sur + Safari 15.2:
image

Issues for so far:

  • Some tooltips are too short
  • Weird sea color (Might be safari changing the color, maybe we can disable this somehow)
  • When terrain rendering is disabled, the map gets drawn twice on startup (also happens on other browsers now that I checked)

Furthermore, I still get these errors in the console:
image
@crschnick crschnick added the map label Jan 24, 2022
@crschnick
Copy link
Collaborator Author

When terrain is enabled, the sea texture is not rendered:
image

nickbabcock added a commit that referenced this issue Jan 24, 2022
@nickbabcock
Add Safari 15.2+ to the supported browsers list
748efdb 
Confirmed to be working in #6.

Looks like some bugs remain (#23), so Safari isn't included in the
"Works best in" line. Instead it's listed as supported.
@nickbabcock nickbabcock mentioned this issue Jan 24, 2022
Merged
nickbabcock added a commit that referenced this issue Jan 25, 2022
@nickbabcock
Reduce map re-renders
9b037e7 
As pointed out in #23 the map renders a couple times too many. The cause
is due to the map payload objects changing (not in structural equality,
but in referential equality). The fix is to not only have the map
payload generated when underlying values change.
@nickbabcock nickbabcock mentioned this issue Jan 25, 2022
Merged
@nickbabcock
Copy link
Collaborator

The issues reported may be a different bug, but here is how the site renders on a 15.3 device (which kinda looks to only have security changes from 15.2)

image

Pardon the blurriness of screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
map
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickbabcock @crschnick