Rework home page and file analysis box #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in #42, the file analysis box is filled with too much text. So I decided to sample the ecosystem and find inspiration. There's a common theme between all (or nearly all) of them: - Minimal text - Centered text - Lots of padding - Dashed border - Usage of the phrase "drag and drop" - An icon (!) - A button or obvious indicator to click So I tried to follow their cues the best I could and came up with this before / after: An interesting note is that the "browse" button isn't actually a button -- it is just stylized text. That's because the containing box with the dashed border is the "button", but I needed to give users a visual indicator that the box is clickable. No accessibility worries as it is only a visual indicator and carries no function itself. It's nice to see the [Nielsen Normal group agree][0] with the forethought I had to allow file drops outside drop target, as even when users don't make it to the drop target the file should still be analyzed. One missing feature is an icon. It would be nice to have an icon made kinda like the "xsl, xslx, csv" one except with eu4, ck3, hoi4 (with eu4 most prominent). This would adequately solve #18 as well. This may have swung the pendulum too far in the other direction such that new users may not be given enough context. The home page has also been updated as part of this commit, which highlights a few more features. Closes #42 [0]: https://www.nngroup.com/articles/drag-drop/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #42, the file analysis box is filled with too much
text. So I decided to sample the ecosystem and find inspiration.
There's a common theme between all (or nearly all) of them:
So I tried to follow their cues the best I could and came up with this
before / after:
An interesting note is that the "browse" button isn't actually a button
-- it is just stylized text. That's because the containing box with the
dashed border is the "button", but I needed to give users a visual
indicator that the box is clickable. No accessibility worries as it is
only a visual indicator and carries no function itself.
It's nice to see the Nielsen Normal group agree with the
forethought I had to allow file drops outside drop target, as even when
users don't make it to the drop target the file should still be
analyzed.
One missing feature is an icon. It would be nice to have an icon made
kinda like the "xsl, xslx, csv" one except with eu4, ck3, hoi4 (with eu4
most prominent). This would adequately solve #18 as well.
This may have swung the pendulum too far in the other direction such
that new users may not be given enough context.
The home page has also been updated as part of this commit, which
highlights a few more features.
Closes #42