Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to load/store Garmin SSO data #99

Closed
wants to merge 4 commits into from

Conversation

embear
Copy link
Contributor

@embear embear commented Oct 18, 2023

Garth is able to load and save the SSO data to/from a directory. This speeds up access to Garmin Connect data. Additionally, it is particularly useful when 2FA is enabled in Garmin Connect. Otherwise one has to enter a security code every time you log in, which is very cumbersome when using gcexport in scripts.
Because the data is sensitive and not every user may want to store this data by default, this feature is only enabled if the user specifies the -ss/--session argument along with a directory where the SSO data is stored

@embear embear changed the title Add option to load/store Garmin SSO data Add argument to load/store Garmin SSO data Oct 20, 2023
@embear
Copy link
Contributor Author

embear commented Feb 21, 2024

@pe-st Did you have time to look at this PR? Are there any comments or requests for changes?

@pe-st
Copy link
Owner

pe-st commented Feb 25, 2024

Sorry @embear, I initially had no time and then forgot about your PR.

Thanks for proposing this, it will make life (or at least the use of the script) easier for many users, including me.

I have reordered the prompting for username/password, see my branch feature/pr99 (commit b994968), what do you think?

@embear
Copy link
Contributor Author

embear commented Feb 26, 2024

@pe-st the your branch works fine for me. Thanks for merging the functionality. I'll close this PR.

@embear embear closed this Feb 26, 2024
@pe-st
Copy link
Owner

pe-st commented Mar 3, 2024

Heree's the PR for 4.3 that includes your code: #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants