Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening of Theme Central - If ($dialog(pnp.mts)) { make dialog visible, check item in listbox and show that page } #19

Closed
ghost opened this issue Jul 30, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 30, 2016

L102 - newtheme.mrc

 elseif ($dialog(pnp.mts)) {
    dialog -v pnp.mts
    if (($1 isnum) && ($gettok($did(501,$1),1,32) != $null)) {
      did -c $dname 501 $1
      page.show $1

ought to be:

 elseif ($dialog(pnp.mts)) {
    dialog -v pnp.mts
    if (($1 isnum) && ($gettok($did(pnp.mts,501,$1),1,32) != $null)) {
      did -c pnp.mts 501 $1
      page.show $1

This doesn't resolve the issue. Further down find that pnp.mts needs to be specified as well.

@ghost ghost added the bug label Jul 30, 2016
@ghost
Copy link
Author

ghost commented Jul 31, 2016

image

L104 & L105 are described above.

L1096
Ought to be:

  ; (do nothing if same page as before)
  if ($did(pnp.mts,503) == $1) return

L1099
Ought to be:

  ; If area hasn't been visited yet, we must prep it
  if ($did(pnp.mts,502,$1) == 0) {

L695
Ought to be:

; Returns currently selected item, if any
alias -l curr.item {
  return $did(pnp.mts,416,$did(pnp.mts,404,1).sel)
}

L699
Ought to be:

; Returns sound of currently selected item, if any
alias -l curr.sound {
  return $gettok($did(pnp.mts,415,$didwm(pnp.mts,415,Snd $+ $curr.item *,1)),2-,32)
}

ghost pushed a commit that referenced this issue Jul 31, 2016
@ghost
Copy link
Author

ghost commented Jul 31, 2016

c6dfcf2

@ghost ghost closed this as completed Jul 31, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants