Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Spam in error log if MySQL database temporary is shut down #95

Closed
Dropsuuu opened this issue Jan 27, 2016 · 2 comments
Closed

Comments

@Dropsuuu
Copy link

If database temporary is shut down i have after 20 minutes error log which has over 300mb!
There are over 4000 entites of error per second!
Can you improve it / fix it please?

errors which mostly are repeated:

L 01/27/2016 - 11:17:33: [SM] Native "SMRPG_IsEnabled" reported: Plugin owning this native is currently paused.
L 01/27/2016 - 11:17:33: [SM] Displaying call stack trace for plugin "smrpg/rpgupgrade/smrpg_upgrade_speed.smx":
L 01/27/2016 - 11:17:33: [SM] [0] Line 106, smrpg_upgrade_speed.sp::Hook_GetPlayerMaxSpeedPost()

L 01/27/2016 - 11:17:33: [SM] Native "SMRPG_IsEnabled" reported: Plugin owning this native is currently paused.
L 01/27/2016 - 11:17:33: [SM] Displaying call stack trace for plugin "smrpg/rpgupgrade/smrpg_upgrade_gravity.smx":
L 01/27/2016 - 11:17:33: [SM] [0] Line 187, smrpg_upgrade_gravity.sp::ApplyGravity()
L 01/27/2016 - 11:17:33: [SM] [1] Line 96, smrpg_upgrade_gravity.sp::Hook_OnClientPostThinkPost()

L 01/27/2016 - 11:17:32: [SM] Native "SMRPG_IsEnabled" reported: Plugin owning this native is currently paused.
L 01/27/2016 - 11:17:32: [SM] Displaying call stack trace for plugin "smrpg/rpgupgrade/smrpg_upgrade_ljump.smx":
L 01/27/2016 - 11:17:32: [SM] [0] Line 139, smrpg_upgrade_ljump.sp::LJump_HasJumped()
L 01/27/2016 - 11:17:32: [SM] [1] Line 116, smrpg_upgrade_ljump.sp::OnPlayerRunCmd()

@peace-maker
Copy link
Owner

This is a bug in sourcemod 😞 See #73
I'll try to work around it, by just not calling SetFailState, if the database fails to connect.

peace-maker added a commit that referenced this issue Jan 28, 2016
SourceMod 1.7 and previous don't handle calls to SetFailState correctly
and leave dependent plugins running while the parent plugin is stopped.

If the database failed to connect when the plugin was loaded, the core
plugin would enter an error state. All other plugins like upgrades still
tried to call core's natives like SMRPG_IsEnabled and errored, because
the plugin owning that native isn't running.

This patch works around it, by not entering an error state if the
connection fails, but just logging an error and trying again later. #95
#73 #26
@peace-maker
Copy link
Owner

This should now only occur, if there are more serious problems with the database, than a failed connection on load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants