Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Please create a new release to include the Node 20 version bump #1070

Closed
3 tasks done
felixfontein opened this issue Feb 22, 2024 · 11 comments
Closed
3 tasks done
Assignees

Comments

@felixfontein
Copy link

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

Please create a new release that includes 4eb285e.

Describe the solution you'd like

The last release was in March 2023, and since them quite a few dependencies were bumped. It would be helpful if a new release gets created.

Describe alternatives you've considered

Referencing the commit directly, which is kind of ugly since it doesn't correspond to a version. (We reference versions by hash anyway, with the real version as a comment, and Dependabot updates that fine. But if you start referencing something else that doesn't have a version, Dependabot will likely no longer update the version comment, besides that comment either not being a version or being something else.)

Additional context

No response

@peaceiris
Copy link
Owner

ok

@felixfontein
Copy link
Author

Any indication when such a release could happen?

@jonathan-4iTester
Copy link

@peaceiris, any news?

@Scc33
Copy link

Scc33 commented Apr 3, 2024

Sorry to pile on... but any update?

@peaceiris
Copy link
Owner

peaceiris commented Apr 8, 2024

Thanks all! Could you please try v4.0.0?

- uses: peaceiris/actions-gh-pages@v4.0.0
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    publish_dir: ./public

https://github.com/peaceiris/actions-gh-pages/releases/tag/v4.0.0

@danivovich
Copy link

Thanks all! Could you please try v4.0.0?

- uses: peaceiris/actions-gh-pages@v4.0.0
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    publish_dir: ./public

https://github.com/peaceiris/actions-gh-pages/releases/tag/v4.0.0

@peaceiris Worked well for my use case, no issues with the update, the action ran as expected.

@peaceiris
Copy link
Owner

Thanks!

The v4.0.0 tag has been released and the v4 tag is also available now!

https://github.com/peaceiris/actions-gh-pages/releases/tag/v4.0.0

@maxkratz
Copy link

maxkratz commented Apr 8, 2024

The v4.0.0 tag has been released and the v4 tag is also available now!

https://github.com/peaceiris/actions-gh-pages/releases/tag/v4.0.0

Thank you, the tag v4 worked for me.

@BornToBeRoot
Copy link

Seems to work for me. Thanks!

@Scc33
Copy link

Scc33 commented Apr 8, 2024

Works like a charm. Thanks!

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants