Optional empty commits #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaceiris
requested review from
peaceiris
and removed request for
peaceiris
peaceiris
reviewed
Sep 14, 2019
peaceiris
force-pushed
the
optionalEmptyCommits
branch
from
b79ceeb
to
5aaeab2
Compare
|
After some testing, I will merge this Pull Request and release |
peaceiris
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it was easier than I anticipated. This should address #21.
I'm not sure if you wanted to standardize around
envor using theinputs/withfeature. I went withinputs` because it allowed for a more explicit default value if it is not provided, and at the end of the day I think it all gets exposed the same way.I also played with doing a more consolidated change to the bash file (not using
if), but this way seems cleaner when it comes to non-zero exit codes fromgit commit.I did test this with my own site, and confirmed it works as expected when making website changes, when making non-website changes, and when the parameter is not defined (as it will be for pretty much everyone using this once it's released).