Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GHES support 馃彚 #580

Merged
merged 3 commits into from
Mar 9, 2021
Merged

feat: Add GHES support 馃彚 #580

merged 3 commits into from
Mar 9, 2021

Conversation

mambax
Copy link
Contributor

@mambax mambax commented Mar 9, 2021

  • Needed to add .husky/_ to .gitignore
  • Not sure about the SSH stuff I did, not an expert there

I used my internal fork to test:

image

It works.

I added a second origin to my repo and pushed it here to make the PR. Let me know any corrections 馃槉

This should fix #579

@mambax mambax requested a review from peaceiris as a code owner March 9, 2021 08:04
@peaceiris peaceiris added dependencies Pull requests that update a dependency file documentation labels Mar 9, 2021
.gitignore Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #580 (4046705) into main (a0db9b6) will increase coverage by 0.56%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   61.17%   61.73%   +0.56%     
==========================================
  Files           4        4              
  Lines         273      277       +4     
  Branches       48       49       +1     
==========================================
+ Hits          167      171       +4     
  Misses        105      105              
  Partials        1        1              
Impacted Files Coverage 螖
src/set-tokens.ts 43.24% <75.00%> (+0.77%) 猬嗭笍
src/git-utils.ts 52.94% <100.00%> (+1.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a0db9b6...4046705. Read the comment docs.

@peaceiris peaceiris changed the title Add GHES support 馃彚 feat: Add GHES support 馃彚 Mar 9, 2021
Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you wonderful job! Since I have no permission to push this pull-request, I will improve these changes in another pull-request.

@peaceiris peaceiris merged commit 3623583 into peaceiris:main Mar 9, 2021
peaceiris pushed a commit that referenced this pull request Mar 9, 2021
Changes for #579

Co-authored-by: dom <dominik.meyer01@sap.com>
@ghost
Copy link

ghost commented Mar 25, 2021

@peaceiris when comes the v4 with this in it? or v3.1? :D
we still use
ghcom-actions/peaceiris-actions-gh-pages@3623583f73a5cfb5ca3632d6234b9564fed73239

@peaceiris
Copy link
Owner

@dominikmeyersap #579 (comment)

@lmussier lmussier mentioned this pull request Jul 13, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Enterprise Compatibility
2 participants