Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to commit hash for external deployment #73

Merged
merged 1 commit into from Jan 6, 2020

Conversation

peaceiris
Copy link
Owner

Close #72

@peaceiris
Copy link
Owner Author

@peaceiris
Copy link
Owner Author

peaceiris commented Jan 6, 2020

@fabiosangregorio

Please try to use peaceiris/actions-gh-pages@v2.8.1-0.

@fabiosangregorio
Copy link

Thank you so much for the responsiveness!
I understand you linked the origin repo's commit message in the external repo's commit message. Unfortunately, as in my use case i deploy from a private repo to an external public repo, I can only see the commit message if I'm logged into my Github account (i.e. other people visiting my external repo can't see what I've changed in that commit).

Would you consider adding the commit description to the external repo's commit message? Or is it bad practice?

Thank you again for the quick response.

@peaceiris
Copy link
Owner Author

I got it. Open #74

@peaceiris
Copy link
Owner Author

This change has enhanced this action. Thank you @fabiosangregorio

@peaceiris peaceiris merged commit fd02997 into master Jan 6, 2020
@peaceiris peaceiris deleted the feat-external-commit-hash branch January 6, 2020 14:10
peaceiris added a commit that referenced this pull request Jan 6, 2020
@peaceiris peaceiris mentioned this pull request Jan 6, 2020
1 task
peaceiris added a commit that referenced this pull request Jan 6, 2020
* feat: Add commitMessage option
* docs: Add custom commit message option

Close #74
cf. #72 and #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Allow option to mirror current commit message on external repo commit message
2 participants