Update instruction on persister warning and update README #6
Conversation
| let persister = new LocalStoragePersister(); | ||
| const c = new Crypto("<>", persister); | ||
| // By default, JS SDK uses in-memory persister. | ||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. |
There was a problem hiding this comment.
So then can we move this warning? There's no more LocalStoragePersister?
| const c = new Crypto("<>", persister); | ||
| // By default, JS SDK uses in-memory persister. | ||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. | ||
| let persister = null; |
There was a problem hiding this comment.
Ok. so what is a null persister and why do I have to do it? :-p
| // By default, JS SDK uses in-memory persister. | ||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. | ||
| let persister = null; | ||
| const c = new Crypto("insert-your-api-key-here", persister); |
There was a problem hiding this comment.
Same question on null persister
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally | ||
| let persister = new LocalStoragePersister(); | ||
| const c = new Crypto("<>", persister); | ||
| // By default, JS SDK uses in-memory persister. |
There was a problem hiding this comment.
I have to pass in a null persister to get this default behavior? Is this more secure? Why? :)
| // By default, JS SDK uses in-memory persister. | ||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. | ||
| let persister = null; |
There was a problem hiding this comment.
Same comments on these 3 lines...
| // By default, JS SDK uses in-memory persister. | ||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. | ||
| let persister = null; | ||
| const c = new Crypto("insert-your-api-key-here", persister); |
There was a problem hiding this comment.
I thought I added the Demo Org APIKEY so that the demo would just work?
| @@ -4,6 +4,7 @@ interface Persister { | |||
| exists(key: string): boolean; | |||
| } | |||
|
|
|||
| // *****WARNING*****: DO NOT USE LocalStoragePersister for any purpose other than testing locally on browser. | |||
There was a problem hiding this comment.
Not sure we can say "DO NOT USE" ... if that's really the case, lets get ride of it...
but I think the bottom line is that "We do not recommend using LocalStoragePersister for high-value data assets" and we can say why, it's much more helpful than just telling them what to do. Discuss the tradeoff between performance and security, it's not our app, it's not our decision, but we can inform them and let them make their own decisions?
No description provided.