-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Fade' animation skip #1
Comments
I can corroborate svinkle's issue. There's something wonky with the 'fade' transition. I'll try and take a look later.. might commit if I can spot the issue. |
If I add a console trace I get double figures being traced back... it appears as though sometimes the setInterval is fired twice and then keeps running like that. |
Same here. Any solutions yet? |
Ok I found a solution for this issue. The setInterval on line 162 fires at the exact same time as the fade animation and that causes the counter to incrememnt twice. That fixes the fading, at least it did for me.. |
Hi there, The fadeOut callback runs twice because that callback fires another fadeIn. So just change this part; el.fadeOut(settings.speed, function() { with this; el.fadeOut(settings.speed, function() { |
Thanks you for solution! |
@timucingelici Thank you for this solution. This should be implemented in https://github.com/peachananr/simple-text-rotator/blob/master/jquery.simple-text-rotator.js asap to avoid future confusion |
I noticed the 'fade' animation seems to skip every other item in the list. Not sure what's up with that.
The text was updated successfully, but these errors were encountered: