command/cp: add progress bar #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmethakanbesel
requested review from
ilkinulas and
sonmezonur
and removed request for
a team
|
love this! |
igungor
reviewed
Jul 25, 2023
ilkinulas
previously approved these changes
Jul 25, 2023
ilkinulas
reviewed
Jul 26, 2023
igungor
reviewed
Jul 26, 2023
|
The more I use it , the more progressbar's position indicator looks invisible to me :) This is a subjective matter of course, but I'd like to propose a minor change. What do you guys think? Before: After: |
igungor
reviewed
Jul 27, 2023
igungor
previously approved these changes
Jul 27, 2023
ilkinulas
approved these changes
Jul 27, 2023
igungor
approved these changes
Jul 27, 2023
igungor
added a commit
that referenced
this pull request
Jul 27, 2023
Resolves #51 Enables usage of cp command with show-progress flag to show progress bar for a copy task. Example progress bar: 78.00% ━━━━━━━━━━━━━━━━━━━━──────── 780 MB / 1.00 GB (189.37 MB/s) 5.9s (28/29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51
Enables usage of
cpcommand withshow-progressflag to show progress bar for a copy task.Example progress bar:
78.00% ━━━━━━━━━━━━━━━━━━━━──────── 780 MB / 1.00 GB (189.37 MB/s) 5.9s (28/29)