Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: extend select api support #611

Merged
merged 62 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
76cf9cc
feat: extend support for select api features
denizsurmeli Jul 23, 2023
424579c
Merge branch 'peak:master' into feat/select-api-support
denizsurmeli Jul 23, 2023
1b65e69
fix: check for lowercase
denizsurmeli Jul 23, 2023
e393d73
feat: split into subcommands
denizsurmeli Jul 24, 2023
eb906ac
refactor: prettier command
denizsurmeli Jul 24, 2023
0119d45
feat: add credential passing configuration in test utilities
denizsurmeli Jul 25, 2023
813468d
try to extend testing, add compression to shared flags
denizsurmeli Jul 25, 2023
bc50544
fix: add testing
denizsurmeli Jul 26, 2023
fc2fdc8
fix: conflicts
denizsurmeli Jul 26, 2023
3fd2a84
c
denizsurmeli Jul 26, 2023
87cca30
refactor: fix staticcheck, make helper easier to read
denizsurmeli Jul 26, 2023
e8b24fa
ci: service container
denizsurmeli Jul 26, 2023
efd2aeb
ci: add service container
denizsurmeli Jul 26, 2023
04b79bd
trigger ci
denizsurmeli Jul 26, 2023
412b4ba
cdkasl
denizsurmeli Jul 26, 2023
d695389
trigger ci
denizsurmeli Jul 26, 2023
ff9a9e3
add version to image
denizsurmeli Jul 26, 2023
5113327
fix yaml indentation
denizsurmeli Jul 26, 2023
4b3cd81
change port
denizsurmeli Jul 26, 2023
bcecf07
change to localhost
denizsurmeli Jul 26, 2023
83b2819
change to localhost
denizsurmeli Jul 26, 2023
737debf
change to localhost
denizsurmeli Jul 26, 2023
01e02ad
change to localhost
denizsurmeli Jul 26, 2023
9269909
change to localhost
denizsurmeli Jul 26, 2023
fbbc5b0
set creds
denizsurmeli Jul 26, 2023
2154a86
set creds
denizsurmeli Jul 26, 2023
02e680a
feat: add service containers
denizsurmeli Jul 26, 2023
5e2cbb2
change 0.0.0.0 to localhost
denizsurmeli Jul 26, 2023
d5165b5
testing: add parquet testing
denizsurmeli Jul 26, 2023
1b3d4c9
chore: add descriptive errors during testing
denizsurmeli Jul 27, 2023
23465a7
test: extend it
denizsurmeli Jul 27, 2023
b25e177
feat: add default fallback to not break the api
denizsurmeli Jul 27, 2023
33c2dc5
chore: put the newlines back
denizsurmeli Jul 27, 2023
485c972
fix: bucket name on tests
denizsurmeli Jul 27, 2023
b5f5b16
Merge branch 'master' into feat/select-api-support
denizsurmeli Jul 28, 2023
5242e81
chore: fix conflicts
denizsurmeli Jul 28, 2023
2426171
chore: change env variable, make tests more readable
denizsurmeli Jul 28, 2023
c0dac23
fix: less strict compression
denizsurmeli Jul 31, 2023
1d50d12
refactor: change help template name
denizsurmeli Jul 31, 2023
cd8980c
fix: assert query to be non-empty
denizsurmeli Jul 31, 2023
0cde3c5
Merge branch 'master' into feat/select-api-support
denizsurmeli Jul 31, 2023
126cb95
refactor: make compression non-shared
denizsurmeli Aug 1, 2023
66a20b1
fix: add compression to default fallback
denizsurmeli Aug 1, 2023
d895119
refactor: extended examples, update options, default output inference
denizsurmeli Aug 3, 2023
0efbd5d
Merge branch 'master' into feat/select-api-support
igungor Aug 4, 2023
d6692eb
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 4, 2023
c0ea6b9
cmd: add use-header option to csv subcmd
denizsurmeli Aug 5, 2023
223f0b1
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 8, 2023
f4eb26e
fix: help documentation
denizsurmeli Aug 8, 2023
213fd37
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 8, 2023
d1ff91e
fix: remove unnecessary else block
denizsurmeli Aug 8, 2023
a815c95
test: update test suite, extend feature coverage and add missing cases
denizsurmeli Aug 20, 2023
b2bd640
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 20, 2023
540e397
Merge branch 'master' into feat/select-api-support
igungor Aug 21, 2023
b5ace8d
Update command/select.go
igungor Aug 21, 2023
00bbc5b
Update command/select.go
igungor Aug 21, 2023
a0e3dc8
Update command/select.go
igungor Aug 21, 2023
4dd4123
Update command/select.go
igungor Aug 21, 2023
71ef73a
doc: add comment about the operation
denizsurmeli Aug 21, 2023
f1aef24
chore: update examples
denizsurmeli Aug 21, 2023
f320c74
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 21, 2023
fef36de
Merge branch 'master' into feat/select-api-support
denizsurmeli Aug 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,28 @@ jobs:

name: test (${{ matrix.os }}/go-${{ matrix.go-version }})
runs-on: ${{ matrix.os }}-latest
services:
minio:
image: ${{ (matrix.os == 'ubuntu') && 'bitnami/minio:2023.7.18' || ''}}
ports:
- 45677:9000
options: >-
--health-cmd "curl -I http://localhost:9000/minio/health/live -s"
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
MINIO_ROOT_USER: minioadmin
MINIO_ROOT_PASSWORD: minioadmin
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-version }}

- run: make test

env:
S5CMD_TEST_ENDPOINT_URL: ${{ (matrix.os == 'ubuntu') && 'http://localhost:45677' || '' }}
qa:
strategy:
matrix:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
#### Breaking changes

#### Features
- Added file types to `select` queries with more range of options to set during the query. ([#494](https://github.com/peak/s5cmd/issues/494))
- Added `--content-disposition` flag to `cp` command. ([#569](https://github.com/peak/s5cmd/issues/569))
- Added `--show-fullpath` flag to `ls`. ([#596](https://github.com/peak/s5cmd/issues/596))
- Added `pipe` command. ([#182](https://github.com/peak/s5cmd/issues/182))
- Added `--show-progress` flag to `cp` to show a progress bar. ([#51](https://github.com/peak/s5cmd/issues/51))
- Added `--include` flag to `cp`, `rm` and `sync` commands. ([#516](https://github.com/peak/s5cmd/issues/516))


#### Improvements
- Implemented concurrent multipart download support for `cat`. ([#245](https://github.com/peak/s5cmd/issues/245))
- Upgraded minimum required Go version to 1.19. ([#583](https://github.com/peak/s5cmd/pull/583))
Expand Down