Install the libgbm-dev package

[papandreou]

It's a new requirement of puppeteer 3: puppeteer/puppeteer#5661

[papandreou]

@vgrigoruk, thanks a lot for the late night review 🌔 ⌨️

I don't have write access to this repository, so I can't merge it. Could you help with that?

[vgrigoruk]

it seems like I don't have write access as well :)
btw, there is a commit in the upstream repo that doesn't the same (but adds another package): jontewks@939d212

[papandreou]

Hmm, right, it's probably better to go with that, then. That commit seems to be the only difference between our fork's master and the upstream: https://github.com/jontewks/puppeteer-heroku-buildpack/compare/jontewks:master..peakon:master

I wonder why we created the fork in the first place? For security reasons, so we wouldn't automatically pick up new, potentially evil stuff from upstream?

@deppy, can you help grant write access here (or get the upstream's master merged in)?

[deppy]

@papandreou Did both granted access here and then merged upstream's master:

Updating 7998008..939d212
Fast-forward
 bin/compile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[deppy]

And yeah, we forked all the buildpacks (that are non-official / non-heroku buildpacks) so that we wouldn't introduce possible places for unauthorized executables being introduced.

[papandreou]

Thanks both!

And yeah, we forked all the buildpacks (that are non-official / non-heroku buildpacks) so that we wouldn't introduce possible places for unauthorized executables being introduced.

Okay, makes sense. At least we now that for next time now :)