New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prototypes for PHP 8 #12

Merged

ashnazg merged 1 commit into pear:trunk from remicollet:issue-php8

Aug 11, 2021

Contributor

remicollet commented Aug 11, 2021 •

edited

Loading

Test suite fails with 8.0.9

Running 5 tests
FAIL DB::DB_Error[db_error.phpt]
FAIL DB::Error 2[db_error2.phpt]
FAIL DB::factory[db_factory.phpt]
PASS DB::isManip[db_ismanip.phpt]
PASS DB::parseDSN[db_parsedsn.phpt]
wrote log to "/builddir/build/BUILD/php-pear-DB-1.11.0/DB-1.11.0/tests/run-tests.log"
TOTAL TIME: 00:00
2 PASSED TESTS
0 SKIPPED TESTS
3 FAILED TESTS:

With this patch

PASS DB::DB_Error[db_error.phpt]
PASS DB::Error 2[db_error2.phpt]
PASS DB::factory[db_factory.phpt]
PASS DB::isManip[db_ismanip.phpt]
PASS DB::parseDSN[db_parsedsn.phpt]
TOTAL TIME: 00:01
5 PASSED TESTS
0 SKIPPED TESTS


          fix prototypes for PHP 8

eefc387

ashnazg approved these changes

View reviewed changes

ashnazg merged commit 6425c70 into pear:trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment