Manage E_DEPRECATED #27
Conversation
raised with 8.3 in pear.php
tests/db_error2.phpt
Outdated
| if (defined('E_DEPRECATED')) { | ||
| if ($errno & E_DEPRECATED | ||
| && (error_reporting() & E_DEPRECATED) != E_DEPRECATED) { | ||
| // Ignore E_STRICT notices unless they have been turned on |
There was a problem hiding this comment.
Copy/paste error: E_DEPRECATED
There was a problem hiding this comment.
What error? They all look spelled correct to me... ?
There was a problem hiding this comment.
// Ignore E_STRICT notices unless they have been turned on
^^^^^^^
There was a problem hiding this comment.
Ah, I see now... I had interpreted E_DEPRECATED as a subset of E_STRICT just looking at the small diff context around this change, but now I can see there is a similar condition block for E_STRICT itself.
@remicollet , could up correct this comment?
tests/db_error2.phpt
Outdated
| if (defined('E_DEPRECATED')) { | ||
| if ($errno & E_DEPRECATED | ||
| && (error_reporting() & E_DEPRECATED) != E_DEPRECATED) { | ||
| // Ignore E_STRICT notices unless they have been turned on |
There was a problem hiding this comment.
Ah, I see now... I had interpreted E_DEPRECATED as a subset of E_STRICT just looking at the small diff context around this change, but now I can see there is a similar condition block for E_STRICT itself.
@remicollet , could up correct this comment?
raised with 8.3 in pear.php