whew - phpUnit's documentation is sorely lacking in the how to install and run your first test department.
I apologize for the delay.
Most importantly, I discovered that I broke all the add*() methods.
addEmail('email@example.com'); // oops, this is now overwriting the 1st, rather than adding an iteration
I have updated Build/Vcard.php to fix this.
I also need to add a file to the repository (a small image to the tests dir) for testing set('PHOTO') and/or set('LOGO').
apparently this can't be done via the web interface, I will need to add from home.
I broke all the add*() methods such that they only set the first iteration
addEmail('firstname.lastname@example.org'); // should not be overwriting the above!
tests set() for all standard properties and tests all add*() and set*() methods. tests still need to be created to test that get() / fetch() return properly escaped and encoded strings
completed the testPropertyGroups and testParameters tests
now uses the set() method
not sure where this is seen/used... updated examples to use the new set() method
This pull request passes (merged 39a3b1d into 36d31ea).
imaged used to test setting PHOTO
This pull request passes (merged 410e4d8 into 36d31ea).
This pull request passes (merged e4a7a20 into 36d31ea).
This pull request passes (merged 4eabd3f into 36d31ea).
I will take a look tomorrow – thanks for helping! :)
Spaces / coding style here - Run PHPCS over the code.
Style (I know what is there is not right, but it's better to fix it)
after running phpCS
I'm still not gitHub proficient, but I've updated 4 files to make phpCS mostly happy (at least happy concerning any edits I've made). Let me know if the updates aren't part of my open pull request. Or if I need to to do anything else.
I was wondering about that... the "new" in the depreciate methods was something I was going to add until I looked at this fix. Going to try it out.
@generalredneck @bkdotcom What should we do here?
I believe @generalredneck is is saying all is well. and this fix is Ready to be Tested By the Community
@generalredneck @bkdotcom Can either of you help my merging master into this?
Merge remote-tracking branch 'refs/remotes/pear/master'
PHPUnit updates + .gitattributes
phpunit updates & whitespace
added .gitattributes: "* text eol=lf"
test was failing due to line-ending conversion
2.5 years later...
master has been merged into this pull-request