Skip to content

Commit

Permalink
The 'firebug' handler is now usable with Chrome, as well.
Browse files Browse the repository at this point in the history
Request: 18617
  • Loading branch information
jparise committed Jul 17, 2011
1 parent f583dd6 commit 48be398
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 20 deletions.
4 changes: 2 additions & 2 deletions Log/firebug.php
Expand Up @@ -142,7 +142,7 @@ function close()
function flush() {
if (count($this->_buffer)) {
print '<script type="text/javascript">';
print "\nif (('console' in window) && ('firebug' in console)) {\n";
print "\nif ('console' in window) {\n";
foreach ($this->_buffer as $line) {
print " $line\n";
}
Expand Down Expand Up @@ -193,7 +193,7 @@ function log($message, $priority = null)
$this->_buffer[] = sprintf('console.%s("%s");', $method, $line);
} else {
print '<script type="text/javascript">';
print "\nif (('console' in window) && ('firebug' in console)) {\n";
print "\nif ('console' in window) {\n";
/* Build and output the complete log line. */
printf(' console.%s("%s");', $method, $line);
print "\n}\n";
Expand Down
6 changes: 2 additions & 4 deletions package.php
Expand Up @@ -7,11 +7,9 @@
The Log package provides an abstracted logging framework. It includes output handlers for log files, databases, syslog, email, Firebug, and the console. It also provides composite and subject-observer logging mechanisms.
EOT;

$version = '1.12.6';
$version = '1.12.7';
$notes = <<<EOT
- Improved the console handler's stream handling. (Bug 17874)
- Added a 'reopen' configuration parameter to the syslog handler. (Request 18185)
- The backtrace depth is now configurable via setBacktraceDepth(). (Request 18423)
- The 'firebug' handler is now usable with Chrome, as well. (Request 18617)
EOT;

$package = new PEAR_PackageFileManager2();
Expand Down
26 changes: 12 additions & 14 deletions package.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<package packagerversion="1.9.2" version="2.0" xmlns="http://pear.php.net/dtd/package-2.0" xmlns:tasks="http://pear.php.net/dtd/tasks-1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://pear.php.net/dtd/tasks-1.0
<package packagerversion="1.9.4" version="2.0" xmlns="http://pear.php.net/dtd/package-2.0" xmlns:tasks="http://pear.php.net/dtd/tasks-1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://pear.php.net/dtd/tasks-1.0
http://pear.php.net/dtd/tasks-1.0.xsd
http://pear.php.net/dtd/package-2.0
http://pear.php.net/dtd/package-2.0.xsd">
Expand All @@ -25,10 +25,10 @@
<email>jan@horde.org</email>
<active>yes</active>
</lead>
<date>2011-05-25</date>
<time>19:52:08</time>
<date>2011-07-16</date>
<time>19:04:29</time>
<version>
<release>1.12.6</release>
<release>1.12.7</release>
<api>1.0.0</api>
</version>
<stability>
Expand All @@ -37,9 +37,7 @@
</stability>
<license uri="http://www.opensource.org/licenses/mit-license.php">MIT License</license>
<notes>
- Improved the console handler&apos;s stream handling. (Bug 17874)
- Added a &apos;reopen&apos; configuration parameter to the syslog handler. (Request 18185)
- The backtrace depth is now configurable via setBacktraceDepth(). (Request 18423)
- The &apos;firebug&apos; handler is now usable with Chrome, as well. (Request 18617)
</notes>
<contents>
<dir baseinstalldir="/" name="/">
Expand Down Expand Up @@ -143,33 +141,33 @@
<changelog>
<release>
<version>
<release>1.12.6</release>
<release>1.12.7</release>
<api>1.0.0</api>
</version>
<stability>
<release>stable</release>
<api>stable</api>
</stability>
<date>2011-05-25</date>
<date>2011-07-16</date>
<license uri="http://www.opensource.org/licenses/mit-license.php">MIT License</license>
<notes>
- Improved the console handler&apos;s stream handling. (Bug 17874)
- Added a &apos;reopen&apos; configuration parameter to the syslog handler. (Request 18185)
- The backtrace depth is now configurable via setBacktraceDepth(). (Request 18423)
- The &apos;firebug&apos; handler is now usable with Chrome, as well. (Request 18617)
</notes>
</release>
<release>
<version>
<release>1.12.7</release>
<release>1.12.6</release>
<api>1.0.0</api>
</version>
<stability>
<release>stable</release>
<api>stable</api>
</stability>
<date>2011-04-15</date>
<date>2011-05-25</date>
<license uri="http://www.opensource.org/licenses/mit-license.php">MIT License</license>
<notes>
- Improved the console handler&apos;s stream handling. (Bug 17874)
- Added a &apos;reopen&apos; configuration parameter to the syslog handler. (Request 18185)
- The backtrace depth is now configurable via setBacktraceDepth(). (Request 18423)
</notes>
</release>
Expand Down

0 comments on commit 48be398

Please sign in to comment.