Handle call to SplitV64 with IPv4-only string #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example:
```
var_dump(Net_IPv6::SplitV64("13.1.68.3"));
array(2) {
[0] =>
string(0) ""
[1] =>
string(8) "3.1.68.3"
}
```
Notice that the "1" in "13" has disappeared from the front of the
string.
Fixed by this change.
Note that SplitV64 does no validation of the supposed IPv6 and IPv4
parts - that is OK, it is up to the caller to validate the parts (before
or after calling SplitV64) using other functions.
|
This was first noticed and fixed in pfSense commit pfsense/pfsense@cdcd860 |
|
Is anybody maintaining this here any more? |
|
Based on code from 1.3.0b2, this change was already applied. Maybe repo moved out of github. |
|
The Net_IPv6 repo in Github is not the master that PEAR uses. Also (for reasons unknown to me) t is not regularly updated to mirror the current PEAR code. I am making requests to the actual master PEAR SVN repo and bug list at pear.php.net |
|
See comment #14 (comment) |
|
@phil-davis also fixed in 1.3.0b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Notice that the "1" in "13" has disappeared from the front of the
string.
Fixed by this change.
Note that SplitV64 does no validation of the supposed IPv6 and IPv4
parts - that is OK, it is up to the caller to validate the parts (before
or after calling SplitV64) using other functions.