Invalid response arrays were returning false instead of a PEAR_Error

object. Reported by: Thomas Berger
pear · Jun 10, 2008 · fd28152 · fd28152
1 parent 76f0995
commit fd28152
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/SMTP.php b/SMTP.php
@@ -296,8 +296,8 @@ function _parseResponse($valid, $later = false)
         /* Compare the server's response code with the valid code/codes. */
         if (is_int($valid) && ($this->_code === $valid)) {
             return true;
-        } elseif (is_array($valid)) {
-            return in_array($this->_code, $valid, true);
+        } elseif (is_array($valid) && in_array($this->_code, $valid, true)) {
+            return true;
         }
 
         return PEAR::raiseError('Invalid response code received from server',

diff --git a/package.xml b/package.xml
@@ -22,15 +22,15 @@
  <date>2008-04-24</date>
  <time>21:47:43</time>
  <version>
-  <release>1.3.0</release>
+  <release>1.3.1</release>
   <api>1.1.0</api>
  </version>
  <stability>
   <release>stable</release>
   <api>stable</api>
  </stability>
  <license uri="http://www.php.net/license/3_01.txt">PHP License</license>
- <notes>- Add getServiceExtensions (slusarz@curecanti.org, Bug 13763)
+ <notes>- Invalid response arrays were returning false instead of a PEAR_Error object. (Thomas Berger)
  </notes>
  <contents>
   <dir baseinstalldir="Net" name="/">