Remove unneeded code #108
Merged
Remove unneeded code #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason the 2nd PR was created is because no release containing the original fix was ever tagger, and the 2nd PR author didn't look to see if there was an unreleased fix already in the code. |
morrisonlevi
approved these changes
Mar 4, 2020
ashnazg
reviewed
Apr 10, 2020
|
Probably not, but it does change the program flow: it returns earlier to the caller with false, skipping a couple of lines that were executed before these patches became necessary. This may sound a bit academic, but regression testing is a lot easier if you don't have to consider this. A patch should not change the program flow if not absolutely necessary. |
ashnazg
approved these changes
Apr 10, 2020
|
Included in v1.10.11 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @arjendekorte, #106 should never have been merged, since #102 already provided a better fix.