Add SHA-1 verification of package contents #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MD5 has been proven to be insecure, so it is fairly useless for serving as the basis of a verification system.
| @@ -92,6 +92,7 @@ | |||
| baseinstalldir CDATA #IMPLIED | |||
| platform CDATA #IMPLIED | |||
| md5sum CDATA #IMPLIED | |||
| sha1sum CDATA #IMPLIED | |||
There was a problem hiding this comment.
This will probably need to be pushed into the package xsd as well
There was a problem hiding this comment.
Are we talking about:
https://github.com/pear/pearweb/tree/master/public_html/dtd
(Apologies for my ignorance. And/or if this comment isn't necessarily directed at me.)
There was a problem hiding this comment.
Yup :) Throw me a PR for that and I'll apply both, it's quite reasonable - introduce a package2.2.xsd and duplicate the md5sum bits as required
CloCkWeRX
added a commit
that referenced
this pull request
Nov 17, 2013
Add SHA-1 verification of package contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD5 has been proven to be insecure, so it is fairly useless for serving
as the basis of a verification system.
This adds a sha1sum attribute, which is preferentially used if it is available in the package.xml file. Falls back to md5sum for backwards-compatibility.