Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated HttpRequest::setRawPostData() #54

Closed
wants to merge 1 commit into from

Conversation

pharazon
Copy link

Fixed deprecatedHttpRequest::setRawPostData(). HttpRequest::setBody() should be used instead.

@pharazon pharazon closed this Nov 16, 2016
@pharazon pharazon reopened this Nov 16, 2016
@ashnazg ashnazg self-requested a review February 13, 2017 19:08
Copy link
Member

@ashnazg ashnazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be retargeted against the stable branch rather than master.

@ashnazg
Copy link
Member

ashnazg commented Feb 24, 2017

This change tests fine against stable, particularly since it's only involved in a test case.

However, I'm confused by something. I see docs for it here (http://php.net/manual/pl/httprequest.setrawpostdata.php), but I can't find that HttpRequest class documented in the other language versions of the manual.

Any ideas, anyone?

@ashnazg
Copy link
Member

ashnazg commented Feb 24, 2017

Actually, this file is simply part of an old copy of the pecl_http package that's included only for pecl packaging tests. As such, those files should probably stay as they are, representing a particular version of the pecl_http package.

@ashnazg ashnazg closed this Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants