Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to PECL shell script for shared extensions #81

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

petk
Copy link
Contributor

@petk petk commented Nov 26, 2018

Hello,

when PHP is using shared extensions (this goes mainly for the xml and openssl) the php CLI command needs to enable those separately for each required extension that PEAR and PECL are using.

To illustrate this more simply:

When PHP is build with something like

./configure --with-openssl=shared --enable-xml=shared

Then pecl CLI script won't work ok... This patch fixes this.

@petk
Copy link
Contributor Author

petk commented Nov 27, 2018

Worth noting here also is another simpler solution where a simple removal of the -n option from the pecl shell script works just as good. Certain Linux 3rd party repositories, for example, do this kind of approach and it seems to be working also good

@petk
Copy link
Contributor Author

petk commented Dec 1, 2018

@ashnazg sorry to ping you, since I've seen you've done some contributions in the not so distant past here, is there any option that the -n option for the pecl script is removed? I can refactor this pull request if that's a good way to go here then.

Thank you.

@ashnazg
Copy link
Member

ashnazg commented Dec 4, 2018

@petk , yes, refactor to the simpler -n idea, and let me see how the builds react.

When PHP is using shared extensions:

./configure --with-openssl=shared --enable-xml=shared

The -n option in PHP command line (in the PECL shell script) removes them
from being enabled and PECL script won't work ok anymore. This goes mainly
for the xml and openssl PHP extensions which are needed to install PECL
extensions via the https protocol and to parse XML files.
@petk
Copy link
Contributor Author

petk commented Dec 4, 2018

@ashnazg refactored, so now only the -n option has been removed. For example, Ubuntu PHP 7.2 development package for Ubuntu 18.10 uses also such approach where this -n option is omitted.

@ashnazg ashnazg self-assigned this Dec 4, 2018
@ashnazg ashnazg self-requested a review December 4, 2018 19:08
@ashnazg ashnazg merged commit bde0938 into pear:master Dec 4, 2018
@petk petk deleted the patch-extensions branch December 4, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants