Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis builds on PHP 5.4 and 5.5 #99

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Fix Travis builds on PHP 5.4 and 5.5 #99

merged 2 commits into from
Oct 18, 2019

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Sep 4, 2019 •
edited

Alternatively we can remove them altogether.

@sanmai sanmai mentioned this pull request Sep 5, 2019
Merged
CloCkWeRX
CloCkWeRX approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

@CloCkWeRX
Copy link
Member

I'm tempted to say PHP5.5 could be dropped; given its EOL, not supported by travis by default.

That said, this gets the build green, so I'm +1

@CloCkWeRX CloCkWeRX merged commit 9c4d70c into pear:master Oct 18, 2019
@sanmai sanmai deleted the patch-3 branch October 18, 2019 05:04
@sanmai
Copy link
Member Author

sanmai commented Oct 18, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloCkWeRX CloCkWeRX CloCkWeRX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanmai @CloCkWeRX