Merge pull request #76 from miken32/develop

Resolve deprecation notices in modern PHP

composer.json

@@ -16,7 +16,7 @@
         "wiki": "https://github.com/pear2/Net_RouterOS/wiki"
     },
     "require": {
-        "php": ">=5.3.0",
+        "php": ">=5.3",
         "pear2/net_transmitter": ">=1.0.0b1 || dev-develop@dev"
     },
     "require-dev": {

src/PEAR2/Net/RouterOS/Message.php

@@ -180,6 +180,7 @@ protected function getAttribute($name)
      * @see getArgument()
      * @see setArgument()
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new ArrayObject($this->attributes);
@@ -190,6 +191,7 @@ public function getIterator()
      *
      * @return int The number of attributes.
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->attributes);

src/PEAR2/Net/RouterOS/Response.php

@@ -225,7 +225,7 @@ private function _receive(
                     $word = $com->getNextWordAsStream();
                     $ind = fread($word, 1);
                     if ('=' === $ind || '.' === $ind) {
-                        $prefix = stream_get_line($word, null, '=');
+                        $prefix = stream_get_line($word, 0, '=');
                     }
                     if ('=' === $ind) {
                         $value = fopen('php://temp', 'r+b');

src/PEAR2/Net/RouterOS/ResponseCollection.php

@@ -294,6 +294,7 @@ public function __debugInfo()
      *
      * @return int The number of responses in the collection.
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->responses);
@@ -308,6 +309,7 @@ public function count()
      *
      * @return bool TRUE if the offset exists, FALSE otherwise.
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return is_int($offset)
@@ -379,21 +381,21 @@ public function rewind()
     /**
      * Moves the position pointer to a specified position.
      *
-     * @param int|string $position The position to move to. If the collection is
+     * @param int|string $offset The position to move to. If the collection is
      *     indexed, you can also supply a value to move the pointer to.
      *     A non-existent index will move the pointer to "-1".
      *
      * @return Response|false The {@link Response} at the specified position,
      *     or FALSE if the specified position is not valid.
      */
-    public function seek($position)
+    public function seek($offset)
     {
-        $this->position = is_int($position)
-            ? ($position >= 0
-            ? $position
-            : count($this->responses) + $position)
-            : ($this->offsetExists($position)
-            ? $this->responsesIndex[$this->index][$position]
+        $this->position = is_int($offset)
+            ? ($offset >= 0
+            ? $offset
+            : count($this->responses) + $offset)
+            : ($this->offsetExists($offset)
+            ? $this->responsesIndex[$this->index][$offset]
             : -1);
         return $this->current();
     }
@@ -404,6 +406,7 @@ public function seek($position)
      * @return Response|false The next {@link Response} object,
      *     or FALSE if the position is not valid.
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         ++$this->position;
@@ -416,6 +419,7 @@ public function next()
      * @return Response|false The response at the current pointer position,
      *     or FALSE if the position is not valid.
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return $this->valid() ? $this->responses[$this->position] : false;
@@ -427,6 +431,7 @@ public function current()
      * @return Response|false The next {@link Response} object,
      *     or FALSE if the position is not valid.
      */
+    #[\ReturnTypeWillChange]
     public function prev()
     {
         --$this->position;
@@ -440,6 +445,7 @@ public function prev()
      * @return Response|false The last response in the collection,
      *     or FALSE if the collection is empty.
      */
+    #[\ReturnTypeWillChange]
     public function end()
     {
         $this->position = count($this->responses) - 1;
@@ -453,6 +459,7 @@ public function end()
      *     i.e. the pointer position itself, or FALSE if the position
      *     is not valid.
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return $this->valid() ? $this->position : false;
@@ -463,6 +470,7 @@ public function key()
      *
      * @return bool TRUE if the pointer is valid, FALSE otherwise.
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return $this->offsetExists($this->position);

src/PEAR2/Net/RouterOS/Util.php

@@ -952,6 +952,7 @@ public function move($numbers, $destination = null)
      * @return int The number of items, or -1 on failure (e.g. if the
      *     current menu does not have a "print" command or items to be counted).
      */
+    #[\ReturnTypeWillChange]
     public function count(Query $query = null, $from = null)
     {
         $countRequest = new Request(