Search collections installed via package manager as well #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like an OK change, but I would like to make the default search the user directory so this isn't a breaking change for people relying on the current behavior. |
stove-panini
commented
Feb 11, 2022
| collection_name = get_collection_name(f) | ||
| docstring_system['collection_name'] = collection_name | ||
| modules_docstrings.append(docstring_system) | ||
|
|
||
| if args.user: |
There was a problem hiding this comment.
The default behavior for --user remains the same since get_files_collections(user=True) is behind this if statement.
|
The default behavior was to ignore the user directory unless the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the snippet generator wasn't finding modules in collections that are installed via package manager (
ansible-collections-ansible-posixin Fedora, for example).I changed up
get_files_user()to a more generalget_files_collections()to search system collections by default and user collections when supplyinguser: Trueto the function.