Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings screen #90

Merged
merged 25 commits into from
Feb 11, 2021
Merged

Settings screen #90

merged 25 commits into from
Feb 11, 2021

Conversation

DreadBoy
Copy link
Collaborator

No description provided.

@DreadBoy
Copy link
Collaborator Author

DreadBoy commented Jan 28, 2021

I'd like to discuss WidgetLibrary. It's a screen with all custom components and is meant for developers to discover these custom components. Goal is to document everything so that new developers don't re-create existing components. I don't like having debugging screens in app but at the same time I think such WidgetLibrary is really useful. Can I get your opinions?

EDIT: Alternative to WidgetLibrary are snapshot (aka golden) tests. These tests render widgets to .png images and compare them with manually approved snaphots (aka goldens) and can be used to catch visual regressions in custom components. New developers could look though these tests to discover custom components instead of WidgetLibrary but this is not as user friendly because tests are spread between multiple files and directories.

@DreadBoy DreadBoy mentioned this pull request Jan 28, 2021
17 tasks
@matejdro
Copy link
Collaborator

I like the idea of the widget library. Maybe button to the library could automatically show up on the bottom of the settings when debug version is opened?

Also, I would appreciate if someone that actually has any experience in flutter widgets would review this instead of me, I mostly checked out logic and found none (which is understandable since features behind this UI are not done yet).

lib/ui/home/home_page.dart Outdated Show resolved Hide resolved
@DreadBoy DreadBoy changed the title Settings screen WIP: Settings screen Jan 28, 2021
@DreadBoy DreadBoy marked this pull request as draft January 29, 2021 08:38
@DreadBoy DreadBoy marked this pull request as ready for review February 6, 2021 21:29
@DreadBoy DreadBoy changed the title WIP: Settings screen Settings screen Feb 6, 2021
@crc-32 crc-32 merged commit 48e47b1 into pebble-dev:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants