-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue i18n POC #167
Vue i18n POC #167
Conversation
We could try extracting the translations from https://github.com/pebble-dev/pebble-appstore-legacy/tree/master/spa |
Oh rad! That's a great place to start. I'll take a look soon. |
Yikes... these script files are crazy! It looks like the whole minified app for each locale. So... I think it's lucky that the i18n info is in a I think the "hard" part will be matching up the translations in the legacy app with the string in the new app. Luckily I only see about 100 strings (and I doubt we implement all of them) so... can't be terrible. I'll try to go through it for English first. |
So I've found a couple of strings that don't seem to be in the legacy pebble app so I think those will have to be translated on our own. |
Yeah sure, I think the best way is to do it manually and then figure out the keys using the english version. Then check what we need and take what's useful and check if anything on our web-app needs to be changed or translated because it's different from what we have. |
I think this is a pretty good example of a common locale file, individual component locales, interpolation in locale strings and locales in directive attributes (not really sure if that's that's the right phrase; I mean things like IMO, I think this a good place to start and we can iterate on this. I might just need help testing all components here. |
@sGerli , are you thinking that this PR should have all english strings put into i18n before merging? Or even more than that? |
Well... it was fun but this doesn't seem to be getting much traction so... I'll close this out for now. |
Context
Just toying around with Vue i18n to see if that would work for internationalization. Seems like it would do the trick for a relatively simple web app like this one.
Thoughts?
I haven't played around with Vue much so I'm definitely open to trying other less Vue specific i18n solutions.
In this screenshot, there's basically no change but... the "Watchfaces" and "Apps" texts are using the "en" translation strings instead of static strings in the template.
![Screen Shot 2020-09-01 at 12 12 15 AM](https://user-images.githubusercontent.com/8609429/91813623-d57e0500-ebe7-11ea-8459-08172c7c57a5.png)
Testing