Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support in text/heading elements #55

Closed
jneubrand opened this issue Mar 14, 2016 · 4 comments
Closed

Unicode support in text/heading elements #55

jneubrand opened this issue Mar 14, 2016 · 4 comments
Milestone

Comments

@jneubrand
Copy link

Unicode characters such as 🎉 (should be encoded as 🎉) throw an InvalidCharacterError instead of being encoded as an HTML entity.

@keegan-lillo
Copy link
Contributor

So it seems base64 encoding is not actually necessary. I'm testing with some different phones but we might be able to solve this by just not base64 encoding the data URI

@keegan-lillo
Copy link
Contributor

#56 resolves this but only for characters like ♥ or 這. Emoji should still be encoded as HTML entities because they show up as blank spaces in editors. Though I suppose that's up to developers.

@jneubrand
Copy link
Author

Fair enough. Closing this

@keegan-lillo
Copy link
Contributor

Will be closed when #56 gets merged.

keegan-lillo added a commit that referenced this issue Mar 15, 2016
Allow unicode characters in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants