Always display all the decimals of the slider's value #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. Feel like writing a test for it? |
|
Yes of course!
|
gregoiresage
force-pushed
the
master
branch
2 times, most recently
from
92149b2
to
b53a7f3
Compare
|
Is this test enough ? |
| assert.strictEqual($valueDisplay.get('value'), '50.00'); | ||
| assert.strictEqual($valueDisplayPad.get('innerHTML'), '50.00'); | ||
| assert.strictEqual($slider.get('value'), '50'); | ||
| $valueDisplay.set('value', 75).trigger('change'); |
There was a problem hiding this comment.
Rather run the setter via the normal API sliderItem.set(75)
|
done |
|
Looks good. Thanks for doing this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also it would be cool if the width of the value-pad would be fixed