Cors snapshot issue #636
Merged
Cors snapshot issue #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathuraMG
reviewed
Mar 5, 2019
server/scripts/export_creds.sh
Outdated
| @@ -29,6 +29,7 @@ S3_BUCKET=`get_secret s3.bucket`$'\n'\ | |||
| PEBLIO_DOMAIN_NAME=`get_secret domain.name`$'\n'\ | |||
| PEBLIO_COOKIE_DOMAIN=`get_secret cookie.domain`$'\n'\ | |||
| PEBLIO_COOKIE_NAME=`get_secret cookie.name`$'\n'\ | |||
| AWS_PROFILE=peblio$'\n'\ | |||
There was a problem hiding this comment.
Just curious, should this be a string? inside ``?
There was a problem hiding this comment.
@komalahuwalia does it matter if this is a string?
MathuraMG
reviewed
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before your pull request is reviewed and merged, please ensure that:
Fixes #123Thank you!