Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
  • Loading branch information
mcrumm and wojtekmach committed Feb 25, 2021
1 parent 6bd00e7 commit 59ca258
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ To query the metadata server for an access token, you must configure
the following:

* `url` must be set to the base url for the metadata server.
* `credentials` must be set to a tuple `{:instance, String.t()}`
* `credentials` must be set to a tuple `{:instance, account}`
with the name of the service account to use.

```elixir
Expand Down
3 changes: 2 additions & 1 deletion lib/goth.ex
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ defmodule Goth do
* `:name` - the name to register the server under.
* `:credentials` - a map of credentials or a tuple `{:instance, String.t()}`.
* `:credentials` - a map of credentials or a tuple `{:instance, account}` (See
"Google Compute Metadata" section in the module documentation for more information.)
* `:cooldown` - Time in milliseconds between retrying requests, defaults
to `#{@cooldown}`.
Expand Down
3 changes: 2 additions & 1 deletion lib/goth/token.ex
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ defmodule Goth.Token do
Config may contain the following keys:
* `:credentials` - a map of credentials or a tuple `{:instance, String.t()}`.
* `:credentials` - a map of credentials or a tuple `{:instance, account}` (See
"Google Compute Metadata" section in the `Goth` module documentation for more information.)
* `:scope` - Token scope, defaults to `#{inspect(@default_scope)}`.
Expand Down

0 comments on commit 59ca258

Please sign in to comment.