Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration and message retention options to Subscription #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ulissesalmeida
Copy link
Contributor

Hello!

In Cloud Pubsub we can specify for how long a message will be retained (https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create#request-body)

We're using these changes on our production system and has been working pretty well.

Our use case:

We create many dynamic subscriptions during the day.
Old subscriptions aren't used, so it ended up with some leftover long-lived subscriptions that we don't use.

It can be dangerous because we have a limit on how many subscriptions we
can have. The default expiration of an inactive subscription is 31 days, we want to reduce it to t
the minimum value that is 1 day.

However, according to the docs, the subscription expiration should
always be greater than the message retention duration. The default
message retention is 7 days, so we need to reduce it together.

Hello!

In Cloud Pubsub we can specify for how long a message will be retained (https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create#request-body)

We're using these changes on our production system and has been working pretty well.

Our use case:

We create many dynamic subscriptions during the day.
Old subscriptions aren't used, so it ended up with some leftover long-lived subscriptions that we don't use.

It can be dangerous because we have a limit on how many subscriptions we
can have. The default expiration of an inactive subscription is 31 days, we want to reduce it to t
the minimum value that is 1 day.

However, according to the docs, the subscription expiration should
always be greater than the message retention duration. The default
message retention is 7 days, so we need to reduce it together.
@ulissesalmeida
Copy link
Contributor Author

Hi @peburrows, is everything alright with this PR? We found very valuable to fine tune how long a message can live in a GCP queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant